Skip to content

feat(ci): add StackBlitz templates for e2e apps #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanbas21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ci): add StackBlitz templates for e2e apps #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Ensure builds run
run: pnpm nx run-many -t build --no-agents

- run: pnpm pkg-pr-new publish './packages/*' './packages/sdk-effects/*' --pnpm --packageManager=pnpm
- run: pnpm pkg-pr-new publish './packages/*' './packages/sdk-effects/*' --template './e2e/*-app' --pnpm --packageManager=pnpm

@coderabbitai coderabbitai Bot Jun 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

fd -p package.json e2e | while read -r pkg; do
  echo "== $pkg =="
  echo "-- package links --"
  jq -r '
    ((.dependencies // {}) + (.devDependencies // {}) + (.peerDependencies // {}))
    | to_entries[]
    | select(.value | test("^(workspace:|file:|link:|catalog:)"))
    | "  \(.key): \(.value)"
  ' "$pkg" || true

  echo "-- scripts --"
  jq -r '
    (.scripts // {})
    | to_entries[]
    | "  \(.key): \(.value)"
  ' "$pkg"
  echo
done

echo "Potential monorepo-only references:"
rg -n --glob 'e2e/*-app/package.json' '"(workspace:|file:|link:|catalog:)|(\.\./)|(\bnx\b)|(\bpnpm -r\b)|(\bturbo\b)' .

Repository: ForgeRock/ping-javascript-sdk

Length of output: 5319

Don't publish the e2e/*-app templates yet

Line 49 now advertises apps that still depend on workspace/catalog resolution and pnpm nx scripts, so pkg-pr-new will keep publishing templates that can't boot in isolation. Gate --template to standalone apps, or add a preflight that rejects monorepo-only deps/scripts before publishing.

🧰 Tools
🪛 zizmor (1.26.1)

[info] 49-49: prefer trusted publishing for authentication (use-trusted-publishing): this command

(use-trusted-publishing)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 49, The pkg-pr-new publish step is
advertising e2e app templates that are not yet standalone. Update the ci
workflow’s publish command so the `--template` selection only includes apps that
can boot independently, or add a preflight in the publish flow to skip/reject
templates that still rely on workspace/catalog resolution or `pnpm nx` monorepo
scripts.


- name: build docs
run: pnpm generate-docs
Expand Down
Loading