Skip to content

add FastEdge app ID to outbound requests for backend correlation#152

Open
ruslanti wants to merge 2 commits into
mainfrom
feat/add-fastedge-app-id-to-outbound-requests
Open

add FastEdge app ID to outbound requests for backend correlation#152
ruslanti wants to merge 2 commits into
mainfrom
feat/add-fastedge-app-id-to-outbound-requests

Conversation

@ruslanti

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 29, 2026 10:20
@ruslanti ruslanti self-assigned this Jun 29, 2026
@ruslanti ruslanti added the enhancement New feature or request label Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a FastEdge application identifier to outbound backend requests (for correlation) and strengthens protections around internal FastEdge routing headers by reserving the fastedge-* / fastedge_* prefix and rejecting direct backend-host access.

Changes:

  • Thread app_id through HTTP/WASI executors into the backend request pipeline and inject it as fastedge-app-id.
  • Block/strip all fastedge-* / fastedge_* headers originating from guest modules.
  • Reject outbound requests that attempt direct access to the configured backend host.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/context.rs Passes app_id into executor constructors so it can be used during outbound requests.
crates/runtime/src/lib.rs Forbids guest-set headers with reserved fastedge-* / fastedge_* prefix in WASI HTTP.
crates/http-service/src/state.rs Filters outbound headers and injects fastedge-app-id; adds tests for new behavior.
crates/http-service/src/executor/wasi_http.rs Persists app_id into the backend instance used by the WASI executor.
crates/http-service/src/executor/http.rs Persists app_id into the backend instance used by the native HTTP executor.
crates/http-backend/src/lib.rs Adds app_id storage/injection, reserved-prefix stripping, and backend-host rejection helpers + tests.
Cargo.lock Dependency lockfile updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/http-service/src/state.rs
Comment thread crates/http-backend/src/lib.rs
Comment thread crates/http-backend/src/lib.rs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Comment thread crates/http-backend/src/lib.rs
Comment thread crates/runtime/src/lib.rs
Comment thread crates/http-backend/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants