feat: well_manager + well estimator#3972
Open
tjb-ltk wants to merge 140 commits into
Open
Conversation
…aint class hierachy , 3) Remove all old constraint handling methods/variables, 4) it compiles ...
…lephase still needs testing
…t compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml
… to fixed and inputFiles regenerated
…d convert compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml" This reverts commit fa61ab1.
…well initialization vagaries assoiated with useSurfaceConditions=0
Co-authored-by: tjb-ltk <149726499+tjb-ltk@users.noreply.github.com>
tjb-ltk
added
ci: run CUDA builds
joshua-white
reviewed
Jul 9, 2026
joshua-white
reviewed
Jul 9, 2026
joshua-white
reviewed
Jul 9, 2026
…for resvol constraint, compositional only
| // set the reference well element where the BHP control is applied | ||
| wellControls.setReferenceGravityCoef( refElev * gravVector[2] ); | ||
| wellControls.setReferenceGravityCoef( refElev * gravVector[2] ); // tjb remove |
joshua-white
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces PR #3735 and extends PR #3971
Overview
This PR introduces
An improved well schema layout and code refactor better suited for well modeling. The previous implementation primarily targeted Jacobian generation requirements for the coupled reservoir and well system.
The well estimator is used to select the active well constraint by solving the well system assuming fixed reservoir conditions and selecting the constraint with the highest or lowest well flowing pressure.
This is a breaking change, detailed migration instructions and migration script are posted at #4081