fix(erc8004): update testnet3 identity registry to match deployed reputation link#6
Open
ProtoJay4789 wants to merge 1 commit into
Open
Conversation
…utation link The Reputation Registry on testnet3 checks identity at 0x54b8..., not 0x5560... as addresses.ts had. This causes giveFeedback to always fail with ERC721NonexistentToken. Fix aligns with on-chain reality. Fixes GOATNetwork#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On GOAT Testnet3, the Reputation Registry is linked to a different Identity Registry than what
plugins/erc8004/addresses.tsspecifies. This causes allgiveFeedbackcalls to fail withERC721NonexistentToken.Root Cause
0x5560...0x54b8...0xd914...Fix
Updated the testnet3 identity registry address to
0x54b8d8e2455946f2a5b8982283f2359812e815ce, matching what the deployed Reputation Registry links to (verified viagetStorageAt).Fixes #4