Token Instance Metadata#787
Open
Jehosephat wants to merge 1 commit into
Open
Conversation
dzikowski
reviewed
Jul 13, 2026
| name: params.name, | ||
| description: params.description, | ||
| image: params.image, | ||
| external_url: params.external_url, |
Collaborator
There was a problem hiding this comment.
by convention we use camelCase - since it's not merged yet, and we don't have actual data on chain, it would be good to align this to our convention
Comment on lines
+61
to
+63
| // the first user to create metadata for a project on a token class becomes | ||
| // the owner of that project's metadata for the whole class | ||
| const ownership = await fetchTokenInstanceMetadataProject(ctx, tokenInstance, project); |
Collaborator
There was a problem hiding this comment.
Doesn't it mean that any user can create metadata for any instance?
Further in the code we verify only the owner of the metadata => if no metadata, or creator === callingUser; then set().
But there is no validation if the instance is owned by the calling user. (like with TokenInstance.owner field, which is required for NFTs). Is it the expected behavior?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The token instance metadata feature is complete, purely additive, and fully verified -- including the mid-flight change to per-project metadata: each NFT instance can now hold multiple metadata documents (one per project), and the first user to create metadata for a project on a token class owns that project's metadata for the whole class.
How the per-project model works
What changed where