fix: Fix listbox row animation reliability to be opt-in and frame rate independent#530
Open
MrS-ibra wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proper reimplementation for listbox entry animations we introduced in #239
The original implementation lived in
LobbyUtils.cppand only worked for specific and sometimes unintended listboxes. This refactor moves all animation logic we introduced intoGadgetListBox.cppwhere it is available to any listbox in the game, and makes it opt-in viaSetListBoxRowAnimModeso only intended listboxes would animate their entry rows.fixes:
Other listboxes can be opted in by calling SetListBoxRowAnimMode at init time