Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Added validation for reserved widget routes and empty chain IDs in the widget registry. - Implemented duplicate Custom Element tag checks during widget registration. - Updated the AuthenticatedWidgetRoute and WidgetRenderer components to include widgetId as a key for better rendering. - Enhanced the RestrictedEip1193Provider to support transaction preparation and improved error handling for signing requests. - Introduced tests for new validation rules and widget registration logic.
|
@copilot |
- Removed outdated comments from various files to enhance code clarity. - Updated the widget registration logic to streamline the integration of React and web component entries. - Adjusted tests to reflect changes in widget registration and validation processes.
- Added unit tests for session storage functionality to ensure proper handling of legacy sessions and private-key sessions. - Refactored session management logic to clear persisted sessions and improve state handling. - Updated session context to include masterSeed for better session management in the UI.
…dation - Introduced reset functionality for wallet connect dialogs to ensure proper state management during user interactions. - Updated widget registration logic to include metadata validation for package name and version, improving integration reliability. - Enhanced tests for wallet connect dialogs and widget registration to cover new validation scenarios and reset behavior.
- Modified the login test to check for wallet actions visibility using test ID instead of text. - Enhanced the claim verification test by clicking the GoodDollar link instead of directly navigating, ensuring better interaction simulation. - Updated screenshots for various onboarding flows to reflect recent UI changes.
- Enhanced the claim verification test by replacing direct URL navigation with a wait for URL method, improving test stability. - Increased timeout for visibility checks to ensure elements are properly rendered before assertions. - Updated the home balances overflow screenshot to reflect recent UI changes.
|
@blueogin delegate to copilot or fix yourself whatever still needs to be done: Please simplify and tighten this PR before it is merged. 1. Revert the session-persistence changes from this PRRestore the existing session behavior in:
PR #54 currently deletes If persisted seeds are considered unsafe when widgets run on the wallet origin, handle that as a separate security task with an explicit product decision, migration plan, and user-facing acceptance criteria. Do not silently change session persistence as part of PR #54. 2. Remove unused backward-compatibility codeSimplify
The only current caller is Also remove unused widget API that exists only for anticipated compatibility, unless a real consumer is added:
3. Start with the minimum provider capability setReduce Keep the provider extensible so a later reviewed registry change can add a method or chain when an actual widget needs it. Do not pre-support 25 methods, 10 chains, and transaction variants without a demonstrated consumer. Retain the security-critical behavior:
Avoid adding generalized transaction normalization, concurrency handling, or compatibility behavior until a concrete flow and test require it. 4. Prove the actual widget flow
Add a minimal test-only widget fixture and desktop/mobile coverage that proves:
|
|
@L03TJ3 Confirmed - that was intentional from my side. I removed session persistence because widgets share origin and could read SIGNER_SESSION / masterSeed from localStorage, bypassing the restricted provider. You’re right that this also forces normal wallets to sign in again after refresh. I’ll revert storage.ts and keep the existing session behavior. |
- Removed unused properties and functions from the RoundButton component to simplify its API. - Refactored session storage logic to improve handling of local storage and session retrieval. - Updated session context to eliminate unnecessary state variables, enhancing clarity and performance. - Introduced a test fixture widget for improved testing capabilities and validation of widget integration. - Enhanced wallet flow tests to include the new test fixture, ensuring comprehensive coverage of widget interactions.
- Added dynamicParams flag to disable dynamic routing for widgets. - Implemented generateStaticParams function to create static routes based on registered widgets. - Updated wallet flow test to check for visibility of 404 error messages for unregistered widget routes. - Updated home balances overflow screenshot to reflect recent UI changes.
|
@L03TJ3 Done - addressed your points: Restored session persistence |
Prepares GoodWallet to host reviewed GoodWidgets through authenticated bottom-sheet routes while keeping wallet authority behind a restricted runtime provider boundary.
Registry and routing
Secure provider boundary
Widget hosts
provider,themeOverrides, andconfigas object properties and clear them on unmount.Dashboard
Coverage