fix: Handle empty strings in StrictWhitespaceControlParser#1319
Merged
Conversation
hs-lsong
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add empty-string guards to
StrictWhitespaceControlParsersohasLeftTrim,hasRightTrim,stripLeft, andstripRightno longer index into an emptytoken.
Why
hasLeftTrimcalledunwrapped.charAt(0)andhasRightTrimcalledunwrapped.charAt(unwrapped.length() - 1)with no empty-string guard. Anytemplate parsed with
withParseWhitespaceControlStrictly(true)that producesan empty unwrapped token (e.g.
{{}}) threwStringIndexOutOfBoundsExceptionduring parsing.
The lenient parser already handles this gracefully —
WhitespaceUtils.startsWith/
endsWithreturnfalsefor null/empty input. This change gives the strictparser the same defensive guarantee, so the two implementations behave
consistently on empty tokens.
Fixing it here protects every consumer of the strict parser rather than
sanitizing input in a single downstream call path.
Behavior change
{{}}now renders to an empty string instead of throwing.{%%}) still errors, but with the expectedUnknown tagerror rather than a
StringIndexOutOfBoundsException— correct downstreambehavior, unchanged in intent.
Tests
StrictWhitespaceControlParserTest: empty token returnsfalsefrom thehasXmethods and is returned unchanged by thestripXmethods; non-emptytrim markers still detected and stripped.
LegacyWhitespaceControlParsingTest.itHandlesEmptyExpressionToken:{{}}renders to
""in strict mode.PR description authored by Claude Code.