ci: Update Node and action versions for PR builds#480
Merged
Conversation
kadler
changed the title
Member
Author
|
Ok, so the problem wasn't Node 20, but that windows-latest now uses VS2026: https://github.blog/changelog/2026-05-14-github-actions-upcoming-image-migrations/#windows-2025-visual-studio-2026-image-migration This breaks Node 22 as well, so we need to switch to windows-2022 regardless (which we also use for release builds). Perhaps it's best to just fix the issue at hand and have separate PR for dropping Node 20 support which can also update the readme, etc. |
windows-latest now uses VS 2026 [1], which Node 20 doesn't understand. find VS unknown version "undefined" found at "C:\Program Files\Microsoft Visual Studio\18\Enterprise" Switch to windows-2022 to continue to use VS 2022. [1] https://github.blog/changelog/2026-05-14-github-actions-upcoming-image-migrations/#windows-2025-visual-studio-2026-image-migration
Node 20 is deprecated within GitHub Actions [1]. Update actions/checkout and actions/setup-node to latest versions which now use Node 24. [1] https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust PR workflow to address Node 20 being deprecated within GitHub actions.
https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners