Skip to content

fix: accept external file drops in dragMoveEvent#669

Closed
b10102016 wants to merge 1 commit into
IENT:developfrom
b10102016:bugfix/drag-drop-external-files
Closed

fix: accept external file drops in dragMoveEvent#669
b10102016 wants to merge 1 commit into
IENT:developfrom
b10102016:bugfix/drag-drop-external-files

Conversation

@b10102016

Copy link
Copy Markdown

Summary

  • dragMoveEvent was calling event->ignore() whenever the cursor was not hovering over an existing playlist item, which silently rejected all OS-level file drops landing on empty playlist space.
  • The flow was: dragEnterEvent correctly accepted URL drops, but dragMoveEvent immediately cancelled them before dropEvent was ever reached.
  • Fix: check hasUrls() at the top of dragMoveEvent and call �cceptProposedAction() for external file drops, bypassing the drop-target logic which only applies to internal item reordering.

Test plan

  • Drag a video/YUV file from Windows Explorer onto the playlist area — file should load
  • Drag a file onto an empty playlist — file should load
  • Drag items within the playlist to reorder — internal reordering still works

🤖 Generated with Claude Code

dragMoveEvent was calling event->ignore() whenever the cursor was not
over an existing playlist item, which rejected all OS-level file drops
landing on empty playlist space. The flow was: dragEnterEvent accepted
URL drops correctly, but dragMoveEvent immediately cancelled them.

Fix by checking hasUrls() first and accepting the action before the
drop-target logic, which is only relevant for internal item reordering.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@b10102016

Copy link
Copy Markdown
Author

Closing in favor of #659 which addresses the same drag-and-drop issue.

@b10102016 b10102016 closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant