Add markup to deprecate transaction 34. - #563
Open
PaulMartinsen wants to merge 6 commits into
Open
Conversation
Removed duplicate entry for transaction DEV-34 deprecation.
There was a problem hiding this comment.
Pull request overview
This PR updates the SDPi documentation set to formally mark transaction DEV-34 as deprecated (since version 2.2.0) and records the change in the project changelog.
Changes:
- Added a changelog entry noting the deprecation registration for DEV-34.
- Added
DeprecateTransaction::DEV-34[version="2.2.0"]markup and removed the activerole=transactiontagging for DEV-34.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
CHANGELOG.md |
Adds an Unreleased entry for the DEV-34 deprecation registration (plus a small formatting change). |
asciidoc/volume2/dev-34/tf2-dev-34.adoc |
Marks DEV-34 as deprecated via semantic markup and disables transaction-role processing for DEV-34. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
JavierEspina
approved these changes
Aug 2, 2026
Contributor
|
@d-gregorczyk, @ToddCooper , this very simple PR is ready to be merged. I just locked my self out by making commits... Please approve and merge ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
This PR adds markup to deprecate transaction 34.
☑ Mandatory Tasks
The following aspects have been respected by the pull request assignee and at least one reviewer: