Skip to content

News 47877: Improve Timeline Panel Visual Layout#11689

Open
matheuszych wants to merge 3 commits into
ILIAS-eLearning:trunkfrom
matheuszych:nw/47877
Open

News 47877: Improve Timeline Panel Visual Layout#11689
matheuszych wants to merge 3 commits into
ILIAS-eLearning:trunkfrom
matheuszych:nw/47877

Conversation

@matheuszych

Copy link
Copy Markdown
Contributor

See: https://mantis.ilias.de/view.php?id=47877

The timeline panel header and footer used float-based spacing and shy
buttons with vertical dividers, which produced an uneven layout. Switched
the header to flexbox, aligned footer actions with
ilTimelinePanelFooter, promoted Like and Notes triggers to standard
buttons, removed the separators, and updated related language strings and
styles.

/cc @thojou

See: https://mantis.ilias.de/view.php?id=47877

The timeline panel header and footer used float-based spacing and shy
buttons with vertical dividers, which produced an uneven layout. Switched
the header to flexbox, aligned footer actions with
`ilTimelinePanelFooter`, promoted Like and Notes triggers to standard
buttons, removed the separators, and updated related language strings and
styles.
@matheuszych

Copy link
Copy Markdown
Contributor Author

The changes unfortunately couldn’t be limited to the news module. We also had to update the Like and Notes components to make this work, so you can expect some related changes in other areas as well.

@alex40724 I’d kindly ask you to review these proposed changes.

@BettyFromHH BettyFromHH added css/html Pull requests that propose changes to CSS/SCSS or HTML files. improvement labels Jun 23, 2026
@BettyFromHH BettyFromHH requested a review from alex40724 June 23, 2026 14:20
@thojou thojou self-assigned this Jun 26, 2026
@thojou thojou requested a review from fhelfer June 26, 2026 09:15

@fhelfer fhelfer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @matheuszych,

changing the button to standard is definitely the right choice.

However the PR changes like#like from “Like” to “React” / “Reagieren”. That key is shared and must stay the label for the 👍 reaction type, not the popover trigger.

It is still used in:

  1. ilLikeGUI::getExpressionText() (components/ILIAS/Like/classes/class.ilLikeGUI.php, ~369) – maps TYPE_LIKE to $lng->txt("like"). Called from ilMembershipCronNotifications::parseNewsItem() (components/ILIAS/Membership/classes/Cron/class.ilMembershipCronNotifications.php, ~301) for course/group notification mails. After this change, thumbs-up reactions appear as “React” / “Reagieren” instead of “Like”.
    Looks like this
Kurs "My Course": "sadfsdf" - sdfsdf
Neue Reaktionen (14)
[dummy5006], 26. Jun 2026, 12:04: Angry
[dummy5003], 26. Jun 2026, 12:04: Laugh
[dummy5002], 26. Jun 2026, 12:04: Love
[dummy5001], 26. Jun 2026, 12:04: Dislike
[dummy5000], 26. Jun 2026, 12:04: Reagieren
[dummy5005], 26. Jun 2026, 12:04: Sad
[dummy5004], 26. Jun 2026, 12:04: Astounded
  1. Emoji counter buttons – Button renderer sets aria-label via getSymbolLabel() → txt("like") for the like glyph (with counter).

The trigger button in getHTML() (~140) may use a new key (e.g. react / add_reaction); like should remain for the expression type.

See: https://mantis.ilias.de/view.php?id=47877

The edited hint was shown for every timeline item because creation and
update dates were compared with `!==` on `DateTime` objects. Switched to
value comparison with `!=`. The comment trigger is now rendered only when
no comments exist yet, and the Like button uses the new `react` language
string instead of overwriting `like`.
@matheuszych

Copy link
Copy Markdown
Contributor Author

Hello @fhelfer ,
thank you for your feedback!

I added a new language variable like#:#react#:#.

Best regards
@matheuszych

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css/html Pull requests that propose changes to CSS/SCSS or HTML files. improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants