fix: Phase 2 code review — critical resilience and state integrity - #31
Merged
Merged
Conversation
Critical: - KEDA ScaledObject API v1alpha1 → v1beta1 - Backend.last_activity_ms==0.0 sentinel (never-active not idle) - wake() resets CircuitBreaker counters; CircuitBreaker.reset() - HealthChecker.update_config() recreates client on timeout change - Telemetry poller rollback on reload failure - Budget store moved after swap section (partial state mutation) - 502 error message sanitization (backend URL removed) Moderate: - _warn_if_changed restored for cost/audit_bus/logging - Rate-limit and session-affinity rebuild warnings - Test imports moved to module level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30, addressing the code review findings.
Critical fixes (7)
v1alpha1→v1beta1Backend.last_activity_ms == 0.0sentinelBackend.wake()skips circuit resetself.circuit.reset()to clearCircuitBreaker.consecutive_failuresHealthChecker.update_config()missingreload_configexcdetails fromGatewayErrormessageModerate fixes (4)
_warn_if_changedcalls restored forcost,audit_bus,loggingsections (accidentally dropped during restructure)HealthCheckerconstructor simplified (removedclock=kwarg which was unused)Validation