feat(core): graph --live observes ChantConfig.stacks in multi-stack projects - #1159
Open
lex00 wants to merge 2 commits into
Open
feat(core): graph --live observes ChantConfig.stacks in multi-stack projects#1159lex00 wants to merge 2 commits into
lex00 wants to merge 2 commits into
Conversation
…rojects The live graph previously only learned extra stacks from component discovery; a project declaring its deployed stacks via ChantConfig.stacks got the single-stack convention and observed nothing. Declared stack names now union into the observation set, same contract lifecycle snapshot/diff already follow. Fixes #1158
This was referenced Jul 28, 2026
…checks vi.fn(() => …) fixes the mock's arity to zero, so chantConfigMock(...a) tripped TS2556 (spread argument must be tuple or rest parameter). A rest parameter on the impl matches how discoverComponentsMock is typed and keeps the mock signature-compatible with the real loadChantConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1158.
graph --liveunioned stacks from component discovery but ignoredChantConfig.stacks, so a declared multi-stack project observed nothing (single-stack convention, no stack named after the env). Declared stack names now join the observation set — the same contractresolveStackTargetsgives lifecycle snapshot/diff.Test: multi-stack config →
observeResourcesreceives every declared stack name; existing single-stack and component-derived behaviors unchanged (25 graph-handler tests green).Found on the aws-bench chant-deployed estate (4 stacks, 3 regions): with this change plus a per-stack-scoped build the live overlay binds; the scoped-build half of full multi-stack graph support is follow-up.