Styling the chat - #1
Draft
kingo2157 wants to merge 6 commits into
Draft
Conversation
IRHM
self-requested a review
October 10, 2020 16:44
IRHM
requested changes
Oct 10, 2020
also fix insertAdjacentHTML inserting before div and scroll to bottom of div with a better method
Owner
|
I added some fixes to your code. Also please don't compile the JS, or if you do make sure you don't commit it by accident. |
IRHM
marked this pull request as draft
October 13, 2020 06:23
kingo2157
commented
Oct 19, 2020
kingo2157
left a comment
kingo2157
left a comment
Contributor
Author
There was a problem hiding this comment.
These are changes that I have viewed; what does this do?
kingo2157
marked this pull request as ready for review
October 19, 2020 21:07
Owner
If you're talking about what I think you are, nothing. It's just a way to organize which changed files you have looked at. Are you done styling? If not, keep the pr as a draft. |
IRHM
marked this pull request as draft
October 20, 2020 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.