test: add threshold operator coverage#767
Open
voltjia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thresholdoperator coverage intests/test_threshold.py.float32,float16, andbfloat16.Motivation
The generated smoke coverage exercises broad PyTorch backend wiring, but each operator still needs direct tests similar to the existing handwritten operator tests. This PR adds one more elementwise operator test while keeping review scope small.
Closes N/A
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Validated as part of a focused activation/elementwise batch including
tests/test_threshold.py:Quality checks:
Test Results on Supported Platforms
Build timing includes the required InfiniRT setup/build plus the InfiniOps focused smoke build.
tests/test_threshold.pytests/test_threshold.pytests/test_threshold.pytests/test_threshold.pytests/test_threshold.pytests/test_threshold.py; pytest summary passed, container returned 137 after summaryFull `pytest` output (optional)
Benchmark / Performance Impact
N/A - test-only PR.
Notes for Reviewers
This PR intentionally adds only one operator test. The branch was validated through a shared elementwise batch to avoid repeating the same six-platform build for each single-file PR.
A local
gelucandidate was included in the five-platform superset run but is not part of this PR batch. It was held back because Ascend reported an independent strided NPUgeluruntime error.