feat: Do not display the review pop-up again if the user clicks no by Elouan1411 · Pull Request #752 · Infomaniak/android-core

Elouan1411 · 2026-04-21T13:17:50Z

No description provided.

Copilot

Pull request overview

Adds a persistent “do not show again” flag to the in-app review gating logic so that once a user declines (via the negative/feedback path), the review prompt won’t be shown in future sessions.

Changes:

Introduce a new DataStore preference key (DO_NOT_SHOW_AGAIN_KEY) with a default value.
Update shouldDisplayReviewDialog to also depend on the new “do not show again” flag.
Persist the “do not show again” flag when the user chooses the feedback/negative action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`InAppReview/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt`	Includes the new flag in the dialog display conditions and writes the flag when the user selects the negative/feedback path.
`InAppReview/src/main/kotlin/com/infomaniak/core/inappreview/AppReviewSettingsRepository.kt`	Adds the new DataStore key and default initial value wiring.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-21T13:23:45Z

PR Reviewer Guide 🔍

(Review updated until commit `8ec8440`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Race Condition In `onUserWantsToGiveFeedback`, both `resetAppReviewSettings()` and `disableReviewDialog()` launch separate coroutines on `Dispatchers.IO` without synchronization. If `resetAppReviewSettings()` executes after `disableReviewDialog()`, it may overwrite the `DO_NOT_SHOW_AGAIN_KEY` value back to false, causing the review dialog to appear again despite the user having already chosen to give feedback. These operations should be combined into a single atomic transaction or properly sequenced to ensure the "do not show again" flag persists. override fun onUserWantsToGiveFeedback(feedbackUrl: String) { onUserWantsToGiveFeedback?.invoke() resetAppReviewSettings() WebViewActivity.startActivity(activity, feedbackUrl) disableReviewDialog()

github-actions · 2026-04-21T13:35:35Z

Persistent review updated to latest commit 5225da1

github-actions · 2026-04-21T14:04:17Z

Failed to generate code suggestions for PR

github-actions · 2026-04-21T14:48:27Z

Persistent review updated to latest commit 8ec8440

github-actions · 2026-04-22T07:48:15Z

Failed to generate code suggestions for PR

github-actions · 2026-04-24T14:22:59Z

Failed to generate code suggestions for PR

FabianDevel

You shouldn't add a new preference.
The logic now is that either way if you click on one or the other button, the popup should not come back.
So you can use a single preference for both

The best should be that you don't do anything by default, and just move the logic of the threshold on the onDismiss action

sonarqubecloud · 2026-05-21T13:00:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

    open fun init(
        countdownBehavior: Behavior = Behavior.LifecycleBased,
        appReviewThreshold: Int? = null,
-        maxAppReviewThreshold: Int? = null,
        onUserWantToReview: (() -> Unit)? = null,
        onUserWantToGiveFeedback: (() -> Unit)? = null


sonarqubecloud · 2026-06-01T12:03:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tevincent · 2026-07-02T14:22:41Z


        val APP_REVIEW_THRESHOLD_KEY = intPreferencesKey("appReviewThresholdKey")
-        val ALREADY_GAVE_REVIEW_KEY = booleanPreferencesKey("alreadyGaveReview")
+        val ALREADY_ASK_REVIEW_KEY = booleanPreferencesKey("alreadyGaveReview")


If you rename the constant, you should rename the key.

tevincent · 2026-07-02T14:33:27Z

-    override fun onUserWantsToDismiss() {
-        resetAppReviewSettings()
-    }
+    override fun onUserWantsToDismiss() = Unit


Why keeping this if it is Unit ?

tevincent · 2026-07-02T14:34:20Z

    private fun <T> getInitialValue(key: Preferences.Key<T>) = when (key) {
        APP_REVIEW_THRESHOLD_KEY -> appReviewThreshold
-        ALREADY_GAVE_REVIEW_KEY -> DEFAULT_ALREADY_GAVE_REVIEW
+        ALREADY_ASK_REVIEW_KEY -> DEFAULT_ALREADY_GAVE_REVIEW


The default has also the wrong name.

Copilot AI review requested due to automatic review settings April 21, 2026 13:17

github-actions Bot assigned Elouan1411 Apr 21, 2026

Copilot started reviewing on behalf of Elouan1411 April 21, 2026 13:18 View session

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from e6a47f9 to acf6c03 Compare April 21, 2026 13:18

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread ...iew/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt Outdated

github-actions Bot added the Review effort 2/5 label Apr 21, 2026

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 5225da1 to acf6c03 Compare April 21, 2026 13:39

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from acf6c03 to e3c8fbb Compare April 21, 2026 14:13

github-actions Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread ...iew/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt Outdated

Elouan1411 force-pushed the rating-pop-up-dont-ask branch 2 times, most recently from e658c64 to 8ec8440 Compare April 21, 2026 14:45

github-actions Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread ...iew/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt Outdated

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 8ec8440 to 2ca15f9 Compare April 22, 2026 07:47

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 2ca15f9 to 9acb957 Compare April 24, 2026 13:58

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 9acb957 to b24e902 Compare April 27, 2026 09:49

FabianDevel requested changes May 21, 2026

View reviewed changes

FabianDevel force-pushed the rating-pop-up-dont-ask branch from b24e902 to c8199eb Compare May 21, 2026 12:59

Elouan1411 force-pushed the rating-pop-up-dont-ask branch 2 times, most recently from 3c5aace to 5943ce0 Compare May 28, 2026 15:36

Elouan1411 requested a review from Copilot May 28, 2026 15:36

Copilot started reviewing on behalf of Elouan1411 May 28, 2026 15:36 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 5943ce0 to 11abef0 Compare May 28, 2026 16:03

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 11abef0 to cff4c1a Compare June 1, 2026 11:58

feat: Do not display the review pop-up again if the user clicks no

dd10b16

Elouan1411 force-pushed the rating-pop-up-dont-ask branch from cff4c1a to dd10b16 Compare June 1, 2026 12:03

tevincent requested changes Jul 2, 2026

View reviewed changes

Uh oh!

Conversation

Elouan1411 commented Apr 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit 8ec8440)

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

FabianDevel left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented May 21, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 1, 2026

Quality Gate passed

Uh oh!

tevincent Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

tevincent Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

tevincent Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Apr 21, 2026 •

edited

Loading

(Review updated until commit `8ec8440`)