Skip to content

COMP: Update remote-module pins toward buildable convergence with main#6688

Open
hjmjohnson wants to merge 1 commit into
InsightSoftwareConsortium:release-5.4from
hjmjohnson:rel54-remote-sync
Open

COMP: Update remote-module pins toward buildable convergence with main#6688
hjmjohnson wants to merge 1 commit into
InsightSoftwareConsortium:release-5.4from
hjmjohnson:rel54-remote-sync

Conversation

@hjmjohnson

Copy link
Copy Markdown
Member

Advance release-5.4 remote-module GIT_TAG pins to reduce drift from main while keeping the branch buildable on release-5.4's module system (56 pins).

For the 41 modules already ingested into main and archived upstream, the pin is the last commit before large-scale code removal — the archival commit rewrites README.rst to info.rst and deletes sources, which breaks itk-module.cmake's file(READ README.rst). Live modules advance to their upstream default-branch HEAD.

Local verification: a clean Release build of the 53 buildable updated modules completed with zero build failures on macOS/arm64. CudaCommon, IOOpenSlide, and Ultrasound are advanced but only exercisable in CI.

Special-case pins
  • TotalVariation 97ea40c4 — the newest commit before it adopts the ITK-6-only itk_module_target(NAMESPACE).
  • LesionSizingToolkit 8d5cba94 — the newest commit before its ITK-6 ITK:: namespaced-target migration.
  • Archived (41) — pinned before README.rst→info.rst / source deletion, so the module still configures under ITK 5.4.
Left at existing pins (not advanced)

Advance release-5.4 remote-module GIT_TAG pins to reduce drift from
main while keeping the branch buildable on release-5.4's module system.

For the 41 modules ingested into main and archived upstream, pin to the
last commit before large-scale code removal: the archival commit
rewrites README.rst to info.rst and deletes sources, which breaks
itk-module.cmake's file(READ README.rst). Live modules advance to their
upstream default-branch HEAD.

Two modules require pins predating their ITK-6-only build changes:
TotalVariation before itk_module_target(NAMESPACE), and
LesionSizingToolkit before the ITK:: namespaced-target migration.

RTK, SphinxExamples, TubeTK, and TractographyTRX are intentionally left
at their existing pins pending upstream fixes and are not advanced here.

Verified by a clean Release build of the 53 buildable updated modules
(all zero build failures). CudaCommon, IOOpenSlide, and Ultrasound are
advanced but only exercisable in CI (no CUDA / OpenSlide / a compatible
VTK on the local macOS host).
@github-actions github-actions Bot added type:Compiler Compiler support or related warnings area:Remotes Issues affecting the Remote module labels Jul 23, 2026
@hjmjohnson
hjmjohnson marked this pull request as ready for review July 23, 2026 02:43
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR advances the release-5.4 remote-module pins toward their upstream versions. The main changes are:

  • Updates 56 remote-module commit hashes.
  • Keeps archived modules before their source-removal commits.
  • Uses compatibility pins for TotalVariation and LesionSizingToolkit.

Confidence Score: 5/5

This looks safe to merge.

No blocking issue is supported by the inspected changed code. The pin-only changes preserve the existing remote-module declarations.

Platform-specific CI should cover CudaCommon, IOOpenSlide, and Ultrasound.

T-Rex T-Rex Logs

What T-Rex did

  • Inspected the TotalVariation pre-check log to verify which tools were looked up and what exit codes were produced.
  • Reviewed the TotalVariation after-configure log to confirm the exact configure attempt, the exit code 127, the intended verbose build command, and the blocker.
  • Linked the two TotalVariation logs as artifacts used to support the contract validation.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
Modules/Remote/CudaCommon.remote.cmake Advances the CudaCommon pin; its CUDA-dependent build path remains CI-dependent.
Modules/Remote/IOOpenSlide.remote.cmake Advances the IOOpenSlide pin; its OpenSlide-dependent build path remains CI-dependent.
Modules/Remote/Ultrasound.remote.cmake Advances the Ultrasound pin; its VTK-dependent build path remains CI-dependent.
Modules/Remote/TotalVariation.remote.cmake Advances to a compatibility pin before the ITK 6 module-target migration.
Modules/Remote/LesionSizingToolkit.remote.cmake Advances to a compatibility pin before the ITK 6 namespaced-target migration.

Reviews (1): Last reviewed commit: "COMP: Update remote-module pins toward b..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Remotes Issues affecting the Remote module type:Compiler Compiler support or related warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant