COMP: Update remote-module pins toward buildable convergence with main#6688
Open
hjmjohnson wants to merge 1 commit into
Open
COMP: Update remote-module pins toward buildable convergence with main#6688hjmjohnson wants to merge 1 commit into
hjmjohnson wants to merge 1 commit into
Conversation
Advance release-5.4 remote-module GIT_TAG pins to reduce drift from main while keeping the branch buildable on release-5.4's module system. For the 41 modules ingested into main and archived upstream, pin to the last commit before large-scale code removal: the archival commit rewrites README.rst to info.rst and deletes sources, which breaks itk-module.cmake's file(READ README.rst). Live modules advance to their upstream default-branch HEAD. Two modules require pins predating their ITK-6-only build changes: TotalVariation before itk_module_target(NAMESPACE), and LesionSizingToolkit before the ITK:: namespaced-target migration. RTK, SphinxExamples, TubeTK, and TractographyTRX are intentionally left at their existing pins pending upstream fixes and are not advanced here. Verified by a clean Release build of the 53 buildable updated modules (all zero build failures). CudaCommon, IOOpenSlide, and Ultrasound are advanced but only exercisable in CI (no CUDA / OpenSlide / a compatible VTK on the local macOS host).
hjmjohnson
marked this pull request as ready for review
July 23, 2026 02:43
Contributor
|
| Filename | Overview |
|---|---|
| Modules/Remote/CudaCommon.remote.cmake | Advances the CudaCommon pin; its CUDA-dependent build path remains CI-dependent. |
| Modules/Remote/IOOpenSlide.remote.cmake | Advances the IOOpenSlide pin; its OpenSlide-dependent build path remains CI-dependent. |
| Modules/Remote/Ultrasound.remote.cmake | Advances the Ultrasound pin; its VTK-dependent build path remains CI-dependent. |
| Modules/Remote/TotalVariation.remote.cmake | Advances to a compatibility pin before the ITK 6 module-target migration. |
| Modules/Remote/LesionSizingToolkit.remote.cmake | Advances to a compatibility pin before the ITK 6 namespaced-target migration. |
Reviews (1): Last reviewed commit: "COMP: Update remote-module pins toward b..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance release-5.4 remote-module
GIT_TAGpins to reduce drift frommainwhile keeping the branch buildable on release-5.4's module system (56 pins).For the 41 modules already ingested into
mainand archived upstream, the pin is the last commit before large-scale code removal — the archival commit rewritesREADME.rsttoinfo.rstand deletes sources, which breaksitk-module.cmake'sfile(READ README.rst). Live modules advance to their upstream default-branch HEAD.Local verification: a clean Release build of the 53 buildable updated modules completed with zero build failures on macOS/arm64. CudaCommon, IOOpenSlide, and Ultrasound are advanced but only exercisable in CI.
Special-case pins
97ea40c4— the newest commit before it adopts the ITK-6-onlyitk_module_target(NAMESPACE).8d5cba94— the newest commit before its ITK-6ITK::namespaced-target migration.Left at existing pins (not advanced)
std::abs<double>(COMP: Fix ill-formed std::abs<double> in ConditionalMedianImageFilter RTKConsortium/RTK#975), plus a 5.4-incompatible lp_solve target-usage refactor.GetKernelMedialnessheader/impl mismatch at all pins.