Skip to content

fix: align iccdev mcp config docs#1705

Merged
xsscx merged 4 commits into
masterfrom
ci-qa-pr-mcp-alignment
Jul 9, 2026
Merged

fix: align iccdev mcp config docs#1705
xsscx merged 4 commits into
masterfrom
ci-qa-pr-mcp-alignment

Conversation

@xsscx

@xsscx xsscx commented Jul 9, 2026

Copy link
Copy Markdown
Member

PR Summary

#1704

Checklist

  • Signed all Commits in PR
  • Built locally according to docs/build.md
  • Followed the guidelines in Contributing document
  • Ran relevant CTest/profile tests from docs/ctest.md
  • Updated documentation for user-visible behavior changes
  • Ran sanitizer coverage for memory-safety or parser changes
  • Added or updated regression coverage for behavior changes
  • For Python package changes, followed docs/python-packaging-release.md for PR and merge requirements
  • Did not change maintainer-owned workflow, CTest, CPack, sanitizer, release, or security infrastructure unless requested by an iccDEV maintainer
  • New source files include the ICC copyright and BSD 3-Clause license header
  • Code style matches nearby code: 2-space indent, K&R braces, m_ members

Legal Requirements

All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).

Contributor License Agreements

Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA)
.

There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.

  • If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.

  • If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement

License

ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.

Copyright Notices

All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.

INTELLECTUAL PROPERTY & PATENTS

Participation in ICC's development activities is subject to ICC's Patent Policy.

Maintainer Review Required

If you have questions, contact a listed Maintainer.

@xsscx xsscx self-assigned this Jul 9, 2026
Copilot AI review requested due to automatic review settings July 9, 2026 00:46
@xsscx xsscx requested a review from ChrisCoxArt as a code owner July 9, 2026 00:46
@xsscx xsscx linked an issue Jul 9, 2026 that may be closed by this pull request
@xsscx xsscx added this to the v2.3.2.3 milestone Jul 9, 2026
@github-actions github-actions Bot added the pending CI checks still running label Jul 9, 2026
@xsscx xsscx added the Copilot Copilot use indicated by Maintainer label Jul 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the iccDEV MCP server configuration and documentation with the maintainer request in issue #1704. It documents the GitHub Copilot coding agent MCP configuration, adds ASCII-safe "display" variants of ICC signature fields to profile_summary, resets the REST dashboard UI state when switching tools, and adds corresponding regression assertions.

Changes:

  • Add a GitHub Copilot coding agent MCP configuration block to the README, mirroring the payload in issue #1704.
  • Add _printable_signature and expose color_space_display/pcs_display/platform_display in profile_summary.
  • Clear stale output and reset run status to Idle when a new tool is selected in the REST dashboard, with Python and UI test coverage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
iccdev-mcp/iccdev_mcp/server.py Adds _printable_signature helper and three *_display fields to profile_summary; the helper is passed raw integer header fields, causing a runtime TypeError.
iccdev-mcp/iccdev_mcp/rest_api.py Resets output to Ready. and runStatus to Idle on tool selection; consistent with existing JS helpers and DOM ids.
iccdev-mcp/tests/test_server.py Adds assertions for the new display fields and printable-ASCII invariant.
iccdev-mcp/tests/rest_dashboard_ui_test.cjs Adds UI regression checks that tool selection clears stale output and resets status.
iccdev-mcp/README.md Documents the Copilot coding agent repository MCP configuration.

Comment thread iccdev-mcp/iccdev_mcp/server.py Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 00:52
@github-actions github-actions Bot added failed One or more CI checks failed and removed pending CI checks still running labels Jul 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread iccdev-mcp/README.md Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 00:58
@xsscx xsscx requested a review from dwtza as a code owner July 9, 2026 00:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@xsscx xsscx merged commit 21f1876 into master Jul 9, 2026
31 checks passed
@xsscx xsscx deleted the ci-qa-pr-mcp-alignment branch July 10, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copilot Copilot use indicated by Maintainer failed One or more CI checks failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify: MCP Server

2 participants