fix: align iccdev mcp config docs#1705
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the iccDEV MCP server configuration and documentation with the maintainer request in issue #1704. It documents the GitHub Copilot coding agent MCP configuration, adds ASCII-safe "display" variants of ICC signature fields to profile_summary, resets the REST dashboard UI state when switching tools, and adds corresponding regression assertions.
Changes:
- Add a GitHub Copilot coding agent MCP configuration block to the README, mirroring the payload in issue #1704.
- Add
_printable_signatureand exposecolor_space_display/pcs_display/platform_displayinprofile_summary. - Clear stale output and reset run status to
Idlewhen a new tool is selected in the REST dashboard, with Python and UI test coverage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
iccdev-mcp/iccdev_mcp/server.py |
Adds _printable_signature helper and three *_display fields to profile_summary; the helper is passed raw integer header fields, causing a runtime TypeError. |
iccdev-mcp/iccdev_mcp/rest_api.py |
Resets output to Ready. and runStatus to Idle on tool selection; consistent with existing JS helpers and DOM ids. |
iccdev-mcp/tests/test_server.py |
Adds assertions for the new display fields and printable-ASCII invariant. |
iccdev-mcp/tests/rest_dashboard_ui_test.cjs |
Adds UI regression checks that tool selection clears stale output and resets status. |
iccdev-mcp/README.md |
Documents the Copilot coding agent repository MCP configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
#1704
Checklist
docs/build.mddocs/ctest.mddocs/python-packaging-release.mdfor PR and merge requirementsm_membersLegal Requirements
All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).
Contributor License Agreements
Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA).
There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.
If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.
If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement
License
ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.
Copyright Notices
All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.
INTELLECTUAL PROPERTY & PATENTS
Participation in ICC's development activities is subject to ICC's Patent Policy.
Maintainer Review Required
If you have questions, contact a listed Maintainer.