feat: wire seller confirmation to approve-milestones (#310) - #336
Open
Killerjunior wants to merge 3 commits into
Open
feat: wire seller confirmation to approve-milestones (#310)#336Killerjunior wants to merge 3 commits into
Killerjunior wants to merge 3 commits into
Conversation
Contributor
|
Hello @Killerjunior could you upload images or video evidence please? |
Author
|
Noted. Uploading now. |
Killerjunior
added a commit
to Killerjunior/SafeSwap
that referenced
this pull request
Jul 22, 2026
Killerjunior
force-pushed
the
feature/issue-310-wire-seller-confirmation
branch
from
July 22, 2026 16:25
71a509f to
05be18a
Compare
Author
|
Screenshots have been added in the PR description as well as walkthrough.md file. Kindly review once more. |
danielcdz
self-requested a review
July 27, 2026 14:22
Contributor
|
Hi @Killerjunior could you resolve conflicts please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 feat: Wire seller confirmation to approve-milestones (#310)
🛠️ Issue
POST /escrow/single-release/v2/approve-milestones#310📖 Description
/p2p/chatwhen accepting a payment request after a buyer marks a milestone as completed.POST /escrow/single-release/v2/approve-milestoneswith{ contractId, approver: sellerAddress, milestoneIndexes: [0] }.unsignedXdrand submits the signed transaction viaPOST /escrow/send-transaction."approved, ready for release"once the transaction is confirmed.✅ Changes made
lib/trustless-work.ts: AddedapproveMilestonesandsendTransactionendpoints totrustlessWork.escrowalongside thesignAndSendTransactionhelper.frontend/components/PaymentBubble: Updated status types and UI rendering to enable the accept button only when the milestone is completed by the buyer, and added the"approved, ready for release"state display.frontend/components/chat/types.ts: UpdatedPaymentStatusandPaymentRequestMessageinterface to includecontractIdandsellerAddress.app/p2p/chat/page.tsx: Created the/p2p/chatpage implementing the full seller confirmation, wallet signing, and state update pipeline.🖼️ Media (screenshots/videos)
📜 Additional Notes
completedfrom the buyer's side.@stellar/freighter-apito enable wallet transaction signing integration.