BBA Compat update - #42
Draft
QuzarDC wants to merge 19 commits into
Draft
Conversation
added 19 commits
July 12, 2026 15:34
Due to KallistiOS/KallistiOS#278 the KOS defines had already been updated to be very close.
The one functional change is that there are now not distinct return errors for each of the failure possibilities in the last 'magic dance'. They aren't being differentiated though, so they could only be used for debug purposes.
These have now been completely replaced by their KOS equivalents.
No functional changes
No functional changes, but to note the configs are different from KOS' default
Tabs to spaces, `{` on same line as statements, `type *`, no
spaces after conditionals, etc
Additionally move defines around gaps code to create a smaller diff. No intentional behavioral change.
These should be functionally identical with the exception that there's no need to define `LOOP_TIMING` alongside the specific one(s) to be printed.
Remove its unused return value, adjust variables and content to match the KOS driver better.
One was as a huge comment previously `weird_extra_init()` which seems to be some RE work for the init sequence. The other is the 'gnarly' function to zero pad undersized packets.
This was previous used in response to overruns but commented out and swapped with a full re-init. Refactor it out to highlight the differences with the implementation vs KOS and remove the commented portion. The only diff with KOS was setting RXCONFIG twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent with these changes is to try to harmonize the style and structure of the dcload-ip BBA driver with KOS' in order to help support improvements in either being moved to the other, additionally to help allow using the dcload driver as a base of testing by cleaning it up some.
Needs substantial review and testing to ensure no accidental regressions. There's still also further updates to be made for pieces like link change. Figured I'd put it up early though for review and commentary.