Skip to content

check khr_android_surface in terminator_CreateAndroidSurfaceKHR#1967

Merged
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
aizu-m:android-surface-ext-check
Jul 13, 2026
Merged

check khr_android_surface in terminator_CreateAndroidSurfaceKHR#1967
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
aizu-m:android-surface-ext-check

Conversation

@aizu-m

@aizu-m aizu-m commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Reading down the surface-creation terminators in wsi.c to check each one gates on its own extension, this line did not match:

loader/wsi.c:1371:  if (!loader_inst->enabled_extensions.khr_display) {

terminator_CreateAndroidSurfaceKHR implements VK_KHR_android_surface but checks the khr_display flag. Every sibling terminator checks its own extension, and the vkGetInstanceProcAddr entry for vkCreateAndroidSurfaceKHR (wsi.c:3016) already gates on khr_android_surface.

Behaviour with the wrong flag: an instance that enables VK_KHR_android_surface but not VK_KHR_display has vkCreateAndroidSurfaceKHR rejected with VK_ERROR_EXTENSION_NOT_PRESENT, and one that enables VK_KHR_display without VK_KHR_android_surface can create an Android surface with the extension off.

Pointed the check and the log message at khr_android_surface.

@ci-tester-lunarg

Copy link
Copy Markdown

Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 38301.

@charles-lunarg charles-lunarg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this code isn't being exercised (to my knowledge), it isn't surprising that this error exists.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3629 running.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3629 passed.

@charles-lunarg charles-lunarg merged commit 85fc457 into KhronosGroup:main Jul 13, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants