Simplify internals and move performance stress test to benchmark - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
listEqualsReelTextwidgetsWhy
The showcase carried a large performance-only UI surface and duplicated small pieces of internal machinery. Keeping stress profiling in an integration benchmark reduces production/example surface area while preserving repeatable performance measurements.
Performance profile
Two macOS profile runs completed successfully. Raster stayed below budget with zero missed raster frames. The measured bottleneck is UI-thread work, especially per-frame chromatic text layout and transition-start text measurement; renderer optimizations are intentionally deferred to a follow-up branch.
Validation
flutter analyzeflutter test(101 tests)cd example && flutter analyzecd example && flutter test(23 tests)performance_benchmark_test.dartdart pub publish --dry-run(0 warnings)