Trim a detection's polygon when its bounding box is shrunk over it#1783
Open
mattdawkins wants to merge 1 commit into
Open
Trim a detection's polygon when its bounding box is shrunk over it#1783mattdawkins wants to merge 1 commit into
mattdawkins wants to merge 1 commit into
Conversation
Resizing a bounding box previously left the detection's polygon untouched, so shrinking the box could leave polygon geometry sticking out beyond it. Box edits now clip any polygon on the detection to the new bounds (Sutherland-Hodgman against the axis-aligned box), dropping a polygon entirely when it falls completely outside. Holes are clipped with the same rule. Rotated boxes are exempt since their stored bounds are the unrotated envelope. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resizing a detection's bounding box leaves its polygon untouched, so shrinking the box past the polygon leaves polygon geometry sticking out beyond the box.
Fix
Box edits now clip any polygon on the detection to the new bounds using a small Sutherland–Hodgman implementation (
clipPolygonToBoundsinsrc/utils.ts, no new dependency):setFeaturestores, so the trimmed polygon is consistent with the persisted box.Unit tests cover containment, single/multi-edge clipping, slanted-edge intersection points, full removal, and hole handling.
🤖 Generated with Claude Code