Display detections flagged with a suppression attribute as suppressed#1785
Open
mattdawkins wants to merge 2 commits into
Open
Display detections flagged with a suppression attribute as suppressed#1785mattdawkins wants to merge 2 commits into
mattdawkins wants to merge 2 commits into
Conversation
A detection outside any suppression region can carry an attribute named
after the suppression type ("Suppressed" by default), set on the track
or on the detection at a frame. Such a detection now stays visible but
is treated as suppressed for display purposes:
- it inherits the suppression type's style (color, opacity, fill) and
its canvas label and hover tooltip show the suppression type, via a
styleType override in LayerManager;
- it no longer counts toward its own type in the type-list totals or
the per-frame counts;
- selecting it still shows its real type, which remains editable; the
attribute only overrides display, never the stored type.
Attribute values true, nonzero numbers, and 'true'/'yes'/'on'/'1' (any
case) are all recognized. Interpolated frames fall back to the previous
keyframe's detection attributes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Region suppression previously hid any detection lying >=50% under a suppression region. The minimum covered fraction is now a setting (Type Settings > Suppression Overlap %), defaulting to 95%, so only detections almost entirely under a region are hidden and excluded from counts. Out-of-range or missing values fall back to the default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Suppression regions (#1760) hide detections lying under a region. But a detection can also be marked suppressed by an attribute — an attribute named after the suppression type ("Suppressed" by default) set true by a pipeline or user — while sitting outside any region. Previously such a detection displayed as its normal type and counted normally, with nothing indicating its suppressed status.
Behavior
A detection carrying the suppression attribute (on the track, or on the detection at the current frame) is treated as a display-only special case:
styleTypein LayerManager, which is the single source feeding every layer's styling, the text label, and the tooltip.Recognized attribute values:
true, nonzero numbers, and'true'/'yes'/'on'/'1'in any case. On interpolated frames the check falls back to the previous keyframe's detection attributes. The suppression-type setting's help text now documents the attribute behavior.Includes unit tests for the attribute-flag parsing and track/detection/interpolated-frame lookups.
🤖 Generated with Claude Code