Skip to content

feat: add throttling of gesture events#48

Open
UlysseDurand wants to merge 1 commit into
Kitware:gesturesfrom
UlysseDurand:gestures
Open

feat: add throttling of gesture events#48
UlysseDurand wants to merge 1 commit into
Kitware:gesturesfrom
UlysseDurand:gestures

Conversation

@UlysseDurand

@UlysseDurand UlysseDurand commented Jul 16, 2026

Copy link
Copy Markdown

This feature was requested in #44

Two consecutive gesture events of the same type are always compressible so all their keys are added to eventKeysToIgnore.

The throttling of events in the EventThrottle.js file uses compression, for a list of events, for consecutive compressible events within that list, only the last one is kept. Gesture events of the same type with different properties are now compressible.

@UlysseDurand UlysseDurand mentioned this pull request Jul 16, 2026

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why your PR mentions the "2 layers" of throttling if you only consider the 2nd layer. It's a bit confusing.

Comment thread vue-components/src/utils/EventThrottle.js
@UlysseDurand

Copy link
Copy Markdown
Author

I'm not sure why your PR mentions the "2 layers" of throttling if you only consider the 2nd layer. It's a bit confusing.

You're right, I changed the PR message to not mention the unused layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants