fix(server): fix server.ready hang on exception#86
Merged
jourdain merged 1 commit intoMay 19, 2026
Conversation
Thibault-Pelletier
marked this pull request as draft
May 13, 2026 12:59
Contributor
Author
|
Missing asyncio.CancelledError case. Converting issue to draft. |
jourdain
reviewed
May 13, 2026
Thibault-Pelletier
force-pushed
the
fix-server-ready-exception
branch
from
May 19, 2026 12:40
092d5a3 to
d6c3f61
Compare
Thibault-Pelletier
marked this pull request as ready for review
May 19, 2026 12:41
Contributor
Author
|
@jourdain this PR is ready for review. FYI, I tried to implement the exited future but the result wasn't very interesting compared to the existing mechanism. So I'll be dropping this idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Kitware/trame#841