Interleave rollout requests across groups - #81
Draft
nightlessbaron wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--rolling-start-sizeto exact sample-level waves instead of truncating the batch to whole groups.Why
The existing rolling start submits complete prompt groups together. With 256 groups × 16 samples and
--rolling-start-size 256, that clusters all 16 siblings from a small set of groups into the same burst. This change produces 16 waves of 256 requests, with one sample from every group in each wave and 15 intervals between waves.Impact
Only the inference rollout scheduler changes. No arguments, configuration, or test files are added.
Validation
git diff --checkpassed.