Offload debug rollout dump to a Ray task; drop routed_experts, add --save-rollout-interval - #83
Draft
nightlessbaron wants to merge 1 commit into
Draft
Offload debug rollout dump to a Ray task; drop routed_experts, add --save-rollout-interval#83nightlessbaron wants to merge 1 commit into
nightlessbaron wants to merge 1 commit into
Conversation
… --save-rollout-interval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--save-debug-rollout-dataserialized the full sample list withtorch.saveon the RolloutManager MainThread. With routed_experts in every sample the dump is ~200GB: ~30 minutes holding the GIL (frozen event loop, idle engines, blocked training handoff) and a peak-memory doubling that can OOM the head node.Three changes:
@ray.remote(num_cpus=1)task — its own worker process, so serialization never blocks the actor. At most one write is in flight; an overlapping dump is skipped with a warning instead of queued.rollout_routed_expertsis dropped from the dump (it dominates the size and the training path already carries it), shrinking the payload ~40x and keeping the object-store handoff cheap.--save-rollout-interval Ndumps only every Nth training rollout (default 1; eval dumps unaffected).Known trade-offs: the final rollout's dump is fire-and-forget, so a job that exits immediately after its last step can leave that one file incomplete; retention's walk-backward delete pairs with interval=1 (gaps from larger intervals can stop it early).