Skip to content

Escape data values in Arrival and Birth clinical-history HTML #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-martyp wants to merge 1 commit into
base: release25.7-SNAPSHOT
Choose a base branch
from
Open

Escape data values in Arrival and Birth clinical-history HTML #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions nirc_ehr/src/org/labkey/nirc_ehr/history/ArrivalDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import org.labkey.api.data.Results;
import org.labkey.api.ehr.history.AbstractDataSource;
import org.labkey.api.module.Module;
import org.labkey.api.query.FieldKey;
import org.labkey.api.util.PageFlowUtil;

import java.sql.SQLException;
Expand All @@ -30,8 +29,7 @@ protected String getHtml(Container c, Results rs, boolean redacted) throws SQLEx

sb.append(safeAppend(rs, "Arrival Type", "arrivalType"));
sb.append(safeAppend(rs, "Acquisition Type", "acquisitionType"));
if (rs.hasColumn(FieldKey.fromString("sourceFacility")) && rs.getObject(FieldKey.fromString("sourceFacility")) != null)
sb.append("Lab Transfer From: " + rs.getString(FieldKey.fromString("sourceFacility")));
sb.append(safeAppend(rs, "Lab Transfer From", "sourceFacility"));

return sb.toString();
}
Expand Down
8 changes: 1 addition & 7 deletions nirc_ehr/src/org/labkey/nirc_ehr/history/BirthDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import org.labkey.api.data.Results;
import org.labkey.api.ehr.history.AbstractDataSource;
import org.labkey.api.module.Module;
import org.labkey.api.query.FieldKey;
import org.labkey.api.util.PageFlowUtil;

import java.sql.SQLException;
Expand All @@ -27,11 +26,6 @@ protected Set<String> getColumnNames()
@Override
protected String getHtml(Container c, Results rs, boolean redacted) throws SQLException
{
StringBuilder sb = new StringBuilder();

if(rs.hasColumn(FieldKey.fromString("Id/Demographics/gender/meaning")) && rs.getObject(FieldKey.fromString("Id/Demographics/gender/meaning")) != null)
sb.append("Gender: " + rs.getString(FieldKey.fromString("Id/Demographics/gender/meaning")));

return sb.toString();
return safeAppend(rs, "Gender", "Id/Demographics/gender/meaning");
}
}