Frontend: Card docs, MobileMockup a11y, Features test, Navbar focus trap - #1135
Open
nanlebenthel-web wants to merge 1 commit into
Open
Frontend: Card docs, MobileMockup a11y, Features test, Navbar focus trap#1135nanlebenthel-web wants to merge 1 commit into
nanlebenthel-web wants to merge 1 commit into
Conversation
…nents - docs(ui): document Card behavior notes in UI_COMPONENTS.md, verified against Card.tsx's actual prop signature - fix(MobileMockup): expose the CSS/SVG phone illustration as a single accessible unit via role="img" + aria-label, hide decorative inner nodes from assistive tech (component has no raster image/next/image asset to add alt text or sizes to) - test(Features): add render coverage asserting all three feature titles and card count - fix(Navbar): wire the mobile menu through useModalDialog for focus trap and Escape-to-close; hamburger button aria-expanded already reflected menu state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cardbehavior (glow/hover) inUI_COMPONENTS.md, cross-checked againstCard.tsx's actual props (children, className, glow, hover). No changes to Card's API.MobileMockup.tsxrenders its phone illustration entirely with inline CSS/SVG, not a raster image, so there's no<img>to add alt text/next/imageto. Instead exposed the mockup as one accessible unit viarole="img"+ a descriptivearia-label, and marked the decorative inner frame/glow nodesaria-hidden.frontend/src/components/Features.test.tsxasserting all three feature titles render and exactly three cards are rendered, using the existing Vitest + Testing Library setup.useModalDialoghook, so focus trap + Escape-to-close only run while the menu is mounted. Hamburger button'saria-expandedalready reflected menu state.Test plan
npx vitest runfor touched/added test files (Features, Navbar, useModalDialog) — all passnpx eslinton changed files — cleannpx vitest run— 184 tests pass; 2 pre-existing failures unrelated to this change (src/lib/dashboard.tsandsrc/hooks/useIncomingStreams.test.tshave pre-existing syntax errors onmain, out of scope here)Closes #1031
Closes #1030
Closes #1029
Closes #1028