Extract shared createRateLimiter factory - #1141
Open
Peolite001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #1099 by extracting a shared
createRateLimiter(options)factory. This consolidates the standard rate limiter configuration into a single location so that bothglobalRateLimiterandstreamCreationRateLimiteruse a uniform setup. This prevents duplication and ensures any future bug fixes or config updates (such as a Redis store setup or IP-keying fixes) will apply consistently to all rate limiters without needing manual syncing across multiple files.Type of Change
Related Issues
Closes #1099
Changes Made
createRateLimiter(options)factory inbackend/src/middleware/rate-limiter.middleware.tsthat includes the shared base config (standardHeaders,legacyHeaders).globalRateLimiterto utilize this new factory instead of a rawrateLimit()call.createRateLimiterinbackend/src/middleware/stream-rate-limiter.middleware.tsfor thecreateStreamRateLimiterfactory.Testing
Test Coverage
Test Steps
Checklist
Additional Notes
This PR specifically focuses on the refactoring requested in the issue. Fixing the trust-proxy IP-keying issue itself and switching rate-limit backends are out of scope for this change and will be addressed in separate PRs/issues as tracked.