refactor(frontend): Extract useAsyncPageData hook for shared page state scaffolding (#1085) - #1142
Open
abdulqoyumadegoke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1085
Overview
Resolves #1085 by extracting a shared
useAsyncPageDatahook infrontend/src/hooks/useAsyncPageData.tsand refactoringactivity-content.tsxandincoming-content.tsxto use it for unified loading, error, hydration, wallet connection, and empty state scaffolding.Key Changes
frontend/src/hooks/useAsyncPageData.ts: Created a reusable custom hook encapsulatinguseWallethydration and connection status, query loading states, error message normalization, and empty list detection.useAsyncPageData.test.ts: Added unit tests covering hydration, wallet status, loading, error string extraction, and empty data scenarios.activity-content.tsx&incoming-content.tsx: Migrated page components to consumeuseAsyncPageDatastate properties.Verification
useAsyncPageDataand existing page components.