fix(config): validate SANDBOX_MODE environment variable explicitly - #1156
Open
Oyinkans0la12 wants to merge 2 commits into
Open
fix(config): validate SANDBOX_MODE environment variable explicitly#1156Oyinkans0la12 wants to merge 2 commits into
Oyinkans0la12 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1100
Summary
Add strict validation for sandbox-related environment variables to ensure invalid configuration values are rejected during application startup instead of being silently coerced.
Problem
backend/src/config/sandbox.tscurrently determines sandbox behavior from environment variables without strict schema validation. Unexpected values such asTRUE,yes, or other non-standard strings may be interpreted incorrectly, potentially enabling or disabling sandbox mode unintentionally.Because sandbox mode controls safety-sensitive behavior, configuration errors should fail fast rather than default to unintended behavior.
Solution
This PR introduces explicit parsing and validation for sandbox-related environment variables, allowing only documented values and rejecting any unsupported input with a clear startup error.
Implementation Details
Configuration Validation
Updated:
backend/src/config/sandbox.tsChanges include:
Error Handling
Invalid configuration now produces an actionable startup error that identifies:
This prevents ambiguous configuration from reaching runtime.
Unit Tests
Added tests covering:
The tests verify both successful parsing and expected startup failures.
Testing
Validated with:
Behavioral Changes
For valid configurations, behavior is unchanged.
Invalid sandbox configuration now causes the application to fail during startup with a clear error instead of silently falling back to unintended behavior.
Checklist