fix(frontend): remove duplicated streams/streams/[streamId] route and add redirect - #1157
Open
omoh5 wants to merge 1 commit into
Open
fix(frontend): remove duplicated streams/streams/[streamId] route and add redirect#1157omoh5 wants to merge 1 commit into
omoh5 wants to merge 1 commit into
Conversation
… add redirect Delete the dead /streams/streams/:streamId route that was a leftover from refactoring streamId to id. Add a permanent redirect in next.config.ts so any external links to the old path land on the canonical stream details page. Closes LabsCrypt#1084
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1084 — removes the dead
/streams/streams/[streamId]route that was a leftover from a previous refactor, and adds a permanent redirect to the canonical/streams/:idroute.Problem
frontend/src/app/streams/streams/[streamId]/page.tsxwas a duplicated dynamic route alongsidefrontend/src/app/streams/[id]/page.tsxstreams/streams/path anywhere in the codebaseChanges
🔴 Removed
frontend/src/app/streams/streams/[streamId]/page.tsx(343 lines deleted)/streams/<id>which resolves to the[id]route🟢 Added
frontend/next.config.ts— permanent redirect (HTTP 308)/streams/streams/:streamId→/streams/:streamIdVerification
npx tsc --noEmit— no new errors (pre-existing errors inuseIncomingStreams.test.tsare unrelated)Out of scope