Fix #837: Update test pool to use configured timeout settings - #999
Open
jotel-dev wants to merge 5 commits into
Open
Fix #837: Update test pool to use configured timeout settings#999jotel-dev wants to merge 5 commits into
jotel-dev wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
escription
closes #837 by ensuring all pg.Pool instances use configurable timeout settings. The integration test was creating a raw pg.Pool without configuration, which has been updated to use the centralized createPgPoolConfig() function to match production behavior.
Type of Change
🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
📚 Documentation update
🔧 Refactoring (no functional changes)
⚡ Performance improvement
🧪 Test addition or update
Related Issues
Closes #837
Changes Made
Updated stream-lifecycle.test.ts to use createPgPoolConfig() instead of creating a raw pg.Pool
This ensures the test pool uses the same timeout settings as production (max, idleTimeoutMillis, connectionTimeoutMillis, statement_timeout)
The main application code (prisma.ts, seed.ts, pg-pool.ts) was already correctly configured with environment variables and sensible defaults
Environment variables for pool settings are already documented in .env.example
Testing
Test Coverage
Integration tests added/updated
Unit tests added/updated
Manual testing performed
Test Steps
The existing integration test suite now uses configured pool settings
Pool settings can be verified by checking that createPgPoolConfig() returns the expected values based on environment variables
Test database connections now respect the same timeout limits as production
Breaking Changes
None - this is a non-breaking change that only affects test configuration to match production behavior.