Start the live session timer only once and dispose it safely - #489
Merged
Conversation
PrepareTimer created a new Timer and AutoResetEvent on every call and replaced the previous instances without disposing them, leaking handles on the singleton TimerManager. The timer state is now guarded by a lock, repeated calls are ignored while a timer is running, and Dispose releases the resources once and resets the started state. Calling PrepareTimer on a disposed manager now throws ObjectDisposedException.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimerManager.PrepareTimercreated a newTimerandAutoResetEventon every call and replaced the previous instances without disposing them. BecauseTimerManageris registered as a singleton andLiveSessionController.GetcallsPrepareTimer, concurrent requests could leak timers and wait handles and start several timers in parallel.The timer state is now guarded by a lock, so repeated or concurrent calls are ignored while a timer is running.
Disposereleases the timer and the reset event exactly once, clears the action, resetsIsTimerStartedand is safe to call multiple times;PrepareTimeron a disposed manager throwsObjectDisposedException. The due time and period were moved into named constants.Linked issues
Closes #197
Review notes
The start guard lives inside
TimerManager, so the existingIsTimerStartedcheck inLiveSessionControllerstays a fast path only and the controller was not changed. New MSTest coverage inF1Server.Tests/WebApi/TimerManagerTests.csverifies the single start behaviour, the concurrent start path, the tick rate after repeated calls, and the disposal behaviour.