Fix case-sensitive path matching in iOS backup description - #12
Merged
Lcharvol merged 1 commit intoJul 30, 2026
Merged
Conversation
The describeIOSBackup function used a case-sensitive range search for "MobileSync/Backup/" in the file path. On macOS, where the filesystem is case-insensitive by default, the actual path casing may differ from the canonical form (e.g. "mobilesync/backup/"). This caused the function to miss the backup root and fall back to a generic description instead of reading the device name and backup date from Info.plist. Switch to a case-insensitive search so the backup metadata is correctly extracted regardless of path casing. Also simplify a confusing guard-let pattern where the nil-coalescing right side was never nil, making the else branch dead code. Replace with a plain let.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
describeIOSBackupfunction inFileDescriptions.swiftused a case-sensitiverange(of:)search for"MobileSync/Backup/"in the file path. On macOS, where the filesystem is case-insensitive by default, the actual path casing may differ from the canonical form (e.g."mobilesync/backup/"). When this happened, the function failed to locate the backup root and fell back to a generic "iOS backup: " label instead of reading the device name and backup date from the backup's Info.plist.Fix
describesIOSBackupWithNonCanonicalCasing) that verifies a lowercase path still produces an "iOS" description.All 9 FileDescriptions tests pass.