Skip to content

Fix test case incorrectly validating exception on empty QueryDelete#3

Closed
LeandroLCD with Copilot wants to merge 1 commit into
developfrom
copilot/sub-pr-2
Closed

Fix test case incorrectly validating exception on empty QueryDelete#3
LeandroLCD with Copilot wants to merge 1 commit into
developfrom
copilot/sub-pr-2

Conversation

Copilot AI commented Nov 17, 2025

Copy link
Copy Markdown

The test build without where clause throws exception included an .and() condition, which prevented it from testing the intended behavior. Due to auto-promotion logic in QueryDelete.build() (lines 207-214), the first logical operation becomes the WHERE clause when none is explicitly set, so no exception would be thrown.

Changes:

  • Removed .and("status", SQLOperator.Equals("status", "active")) from the test to properly validate that building a QueryDelete with no conditions throws IllegalArgumentException

The test now correctly verifies the exception path when both where and operations are empty.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI commented Nov 17, 2025

Copy link
Copy Markdown
Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/agents/gradle-instrumentation-agent-8.13.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.13 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Develop code changes to fix existing issues Fix test case incorrectly validating exception on empty QueryDelete Nov 17, 2025
Copilot AI requested a review from LeandroLCD November 17, 2025 23:59
@LeandroLCD LeandroLCD closed this Dec 9, 2025
@LeandroLCD
LeandroLCD deleted the copilot/sub-pr-2 branch December 9, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants