Fix test case incorrectly validating exception on empty QueryDelete#3
Closed
LeandroLCD with Copilot wants to merge 1 commit into
Closed
Fix test case incorrectly validating exception on empty QueryDelete#3LeandroLCD with Copilot wants to merge 1 commit into
LeandroLCD with Copilot wants to merge 1 commit into
Conversation
Merged
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Develop code changes to fix existing issues
Fix test case incorrectly validating exception on empty QueryDelete
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
build without where clause throws exceptionincluded an.and()condition, which prevented it from testing the intended behavior. Due to auto-promotion logic inQueryDelete.build()(lines 207-214), the first logical operation becomes the WHERE clause when none is explicitly set, so no exception would be thrown.Changes:
.and("status", SQLOperator.Equals("status", "active"))from the test to properly validate that building a QueryDelete with no conditions throwsIllegalArgumentExceptionThe test now correctly verifies the exception path when both
whereandoperationsare empty.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.