Make sensitive-areas gate per-project configurable#179
Merged
Conversation
…alar support to parse_yaml_simple
Member
Author
Review SummaryVerdict: APPROVE Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the reviewer's "force CRITICAL on sensitive areas" rule per-project configurable via two new placeholders:
SENSITIVE_AREAS_GATE—"true"(default) keeps the gate active;"false"removes the section entirely from the generated review-agent prompt.SENSITIVE_AREAS_CATEGORIES— multi-line bulleted markdown that replaces the default 5-category list. Use a YAML block scalar (|) for multi-line content.Defaults match current behavior, so existing projects are unaffected. Smoke-tested both states; with gate
"false"the section is absent from the rendered prompt, with"true"it's present.Adjacent fix in
sync.py: Extendedparse_yaml_simpleto support|block scalars. The schema previously advertised this forPLATFORM_COMPLIANCE_NOTESandCONVENTIONS_NOTESbut the parser didn't actually support it — multi-line bodies would parse as YAML list items underconfig:, breaking sync. Bundled here becauseSENSITIVE_AREAS_CATEGORIESneeds it and the alternatives (inline\nescapes or a separate file) were worse than fixing the parser.Files touched:
config.schema.yaml— schema entries for both placeholders..codecannon.yaml— defaults set so CodeCannon's own sync passes.skills/github-agile/review-agent.md— section wrapped in{{#if SENSITIVE_AREAS_GATE}}with{{SENSITIVE_AREAS_CATEGORIES}}substitution.skills/github-agile/setup.md— added both placeholders to the Optional config list.sync.py—parse_yaml_simpleextended for|block scalars.Closes #174