Make QA-label apply non-blocking in /submit-for-review after merge#184
Merged
Merged
Conversation
Member
Author
Review SummaryVerdict: APPROVE Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the post-merge QA-label apply in
/submit-for-reviewnon-blocking.If
gh issue edit --add-label "{{QA_READY_LABEL}}"fails (e.g. the label does not exist in the repo, orghreturns a non-zero exit), the prompt now instructs the LLM to print a one-line warning showing the stderr and continue to the resolution comment and success report — rather than aborting. The merge has already happened by that point; surfacing the failure is enough.Source change is one sentence in
skills/github-agile/submit-for-review.md; the four adapter outputs (.claude,.cursor,.agents,.gemini) are regenerated by./sync.py --force.A follow-up ticket (#183) was opened for the more durable fix: have
/setupaudit the configured labels once and offer to create any that are missing, so this failure mode is avoided entirely for projects that go through setup.Closes #182