Skip to content

feat(match2): damage dealt graphs in LoL matchpages#7837

Open
ElectricalBoy wants to merge 4 commits into
mainfrom
lol-matchpage-damage-bar-graph
Open

feat(match2): damage dealt graphs in LoL matchpages#7837
ElectricalBoy wants to merge 4 commits into
mainfrom
lol-matchpage-damage-bar-graph

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

Summary

Inspiration: https://discord.com/channels/93055209017729024/276340346831765504/1529080963597074462

This PR adds damage dealt graphs to each game in LoL match pages.

How did you test this change?

https://liquipedia.net/leagueoflegends/Match:ID_User_ElectricalBoy_zqx7pe0nDj_R01-M001

@ElectricalBoy
ElectricalBoy requested review from a team as code owners July 22, 2026 07:15
@ElectricalBoy ElectricalBoy added the g: leagueoflegends League of Legends label Jul 22, 2026

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable on phone

@mbergen

mbergen commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Are there plans to add more graphs? If not, have you considered centering the graph?

@ElectricalBoy

ElectricalBoy commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Are there plans to add more graphs?

eventually, really depends on when more data becomes available on LeagueOfLegendsDB

If not, have you considered centering the graph?

mw.ext.Charts extension does not support automatic resizing based on browser width, so that's really out of our control (would have made the graph to scale automatically otherwise)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants