Skip to content

chore(infobox): remove legacy matchticker call in rocketleague players#7845

Open
ElectricalBoy wants to merge 1 commit into
mainfrom
rl-kick-legacy-match-ticker
Open

chore(infobox): remove legacy matchticker call in rocketleague players#7845
ElectricalBoy wants to merge 1 commit into
mainfrom
rl-kick-legacy-match-ticker

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

Summary

#7830 (comment)

How did you test this change?

trivial

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be plain removed or replaced with "new" matchticker?

@ElectricalBoy

Copy link
Copy Markdown
Collaborator Author

should it be plain removed

yes - the legacy module only adds upcoming matches whose display is already added by commons version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants