refactor: remove mw.html dependency from Html.Fragment#7848
Open
ElectricalBoy wants to merge 1 commit into
Open
refactor: remove mw.html dependency from Html.Fragment#7848ElectricalBoy wants to merge 1 commit into
ElectricalBoy wants to merge 1 commit into
Conversation
hjpalpha
reviewed
Jul 24, 2026
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
have you tested what happens if a module returns fragment (last return to the display)?
i.e. make sure it renders correctly instead of just rendering as table
Collaborator
Author
same as current & covered by existing tests |
hjpalpha
approved these changes
Jul 24, 2026
mbergen
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Html.Fragmentis a thin container of its children that requires no extra processing, i.e., it can be implemented as a simple render function that directly returns itschildren.How did you test this change?
busted