Skip to content

feat(ExternalMediaLink): use tournament data for event information #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElectricalBoy wants to merge 4 commits into
base: main
Choose a base branch
from
+31 −8
Open

feat(ExternalMediaLink): use tournament data for event information #7849

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75dd5e6
use tournament data to automatically fill event data
ElectricalBoy Jul 24, 2026
bc63f51
type safety
ElectricalBoy Jul 24, 2026
073128e
simplify fallback
ElectricalBoy Jul 24, 2026
2904c41
make luals shut up
ElectricalBoy Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions lua/wikis/commons/ExternalMediaLink.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ local Lpdb = Lua.import('Module:Lpdb')
local Namespace = Lua.import('Module:Namespace')
local Page = Lua.import('Module:Page')
local Table = Lua.import('Module:Table')
local Tournament = Lua.import('Module:Tournament')

local Condition = Lua.import('Module:Condition')
local ConditionTree = Condition.Tree
Expand Down Expand Up @@ -73,6 +74,13 @@ function ExternalMediaLink._fallBackArgs(args)
for subjectIndex = 2, MAXIMUM_VALUES.subjects do
args['subject' .. subjectIndex] = args['subject' .. subjectIndex] or args['player' .. subjectIndex]
end

local eventLink = Logic.emptyOr(args['event-link'], args.event)

if Logic.isNotEmpty(eventLink) then
---@cast eventLink -nil
args.tournament = Tournament.getTournament(eventLink)
end
end

---Parses the supplied arguments and returns as LPDB form
Expand All @@ -99,13 +107,14 @@ function ExternalMediaLink._readArgs(args)
'Maximum Value of authors (' .. MAXIMUM_VALUES.authors .. ') exceeded')
lpdbData.authors = authors

---@type StandardTournament
local tournament = args.tournament or {}

local extradata = {
translation = args.translation,
translator = args.translator,
event = args.event,
event_link = Page.pageifyLink(
Logic.emptyOr(args['event-link'], args.event) or ''
),
event = tournament.displayName or args.event,
event_link = tournament.pageName or Page.pageifyLink(Logic.emptyOr(args['event-link'], args.event) or ''),
subject_organization = args.subject_organization1, --legacy
}

Expand Down Expand Up @@ -244,6 +253,23 @@ function ExternalMediaLink._wrapperDisplay(parsedArgs)
}}
end

---@return VNode?
local function eventDisplay()
local tournament = parsedArgs.tournament
if tournament ~= nil then
---@cast tournament StandardTournament
return Link{
link = tournament.pageName,
children = tournament.fullName,
}
elseif Logic.isNotEmpty(parsedArgs.event) then
return Link{
link = parsedArgs['event-link'] or parsedArgs.event,
children = parsedArgs.event,
}
end
end

return TableWidgets.Table{
sortable = false,
columns = {{}, {}},
Expand All @@ -253,10 +279,7 @@ function ExternalMediaLink._wrapperDisplay(parsedArgs)
rowIfNotEmpty('Date', parsedArgs.date),
rowIfNotEmpty('Subject(s)', makeLinkList('subject')),
rowIfNotEmpty('Org Subject(s)', makeLinkList('subject_organization')),
rowIfNotEmpty('Event', parsedArgs.event and Link{
link = parsedArgs['event-link'] or parsedArgs.event,
children = parsedArgs.event,
} or nil),
rowIfNotEmpty('Event', eventDisplay()),
rowIfNotEmpty('URL', parsedArgs.link)
)}},
}
Expand Down
Loading