fix(serializer): leave IRI-referenced translations to native denormalization#83
Merged
Merged
Conversation
…ization TranslatableItemDenormalizer claimed every payload whose translations key was an array, including a list of IRI strings (translations exposed as their own ApiResource, as in Locastic#40). It then skipped the string items, so the references were silently dropped on POST and PATCH, and PUT removed every existing translation because no submitted locale was recorded. Before 2.0.0 API Platform resolved such IRIs natively. Restrict supportsDenormalization to the embedded shape (every item a document): IRI lists and mixed payloads now take the native path again, restoring the pre-2.0 behavior for that shape. The in-loop skip stays as defense for direct denormalize() calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TranslatableItemDenormalizer(new in 2.0.0) claims every payload whosetranslationskey is an array, including a list of IRI strings, the shape used when translations are exposed as their ownApiResource(as in #40). It then skips the string items, so the references are silently dropped onPOSTandPATCH, andPUTremoves every existing translation because no submitted locale is recorded. Before 2.0.0, API Platform resolved such IRIs natively.Changes
supportsDenormalizationto the embedded shape (every item a document): IRI lists and mixed payloads take the native denormalization path again, restoring the pre-2.0 behavior for that shape.denormalize()calls.Verification
bin/phpunit: 66 tests, 131 assertions, green (9 pre-existing deprecations).bin/phpstan analyse --memory-limit=512M: no errors (level 6).bin/php-cs-fixer check: no violations.composer validate --strict: valid.