Skip to content

fix(dfns): multiple migration fixes#335

Merged
wpbonelli merged 2 commits into
MODFLOW-ORG:developfrom
wpbonelli:dfn-fixes
Jul 12, 2026
Merged

fix(dfns): multiple migration fixes#335
wpbonelli merged 2 commits into
MODFLOW-ORG:developfrom
wpbonelli:dfn-fixes

Conversation

@wpbonelli

Copy link
Copy Markdown
Member
  • two records in different blocks with identically-named fields could bleed into one another
  • integer fields that share a name between packagedata and another list record field (e.g. ifno in connectiondata, tables, period, ...) should be inferred as PK/FK pairs
  • disambiguate LAK package number; previously either a lake number or an outlet number depending on which laksetting is active, split out separate lakeno/outletno fields to be unambiguous FKs

@wpbonelli wpbonelli added the bug Something isn't working label Jul 12, 2026
@wpbonelli wpbonelli marked this pull request as ready for review July 12, 2026 15:37
@wpbonelli wpbonelli merged commit 07fc994 into MODFLOW-ORG:develop Jul 12, 2026
10 of 14 checks passed
@wpbonelli wpbonelli deleted the dfn-fixes branch July 12, 2026 15:37
wpbonelli added a commit to modflowpy/pyphoenix-project that referenced this pull request Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant