fix(runner.py): cap Picard iterations with ATS#102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ATS conditional branch in
run_simulation()did not cap Picard iterations. A timestep failing to converge would callmf6.solve()indefinitely instead of giving up aftermaxitertries. This caused crashes (access violations) on Windows in theex-gwt-adv-schemesexample model. I think the "central" scheme is borderline-unstable on this model, it converges on the Linux and macOS builds but can fail on Windows.Note however that ATS is not truly supported right now by the API: there is no way currently to hook into the retry mechanism. This is a temporary stopgap to prevent crashes until ATS is supported. See
Close #98