Make Market Union Member Julia a working warp NPC for the Loren Market

[nolt]

Summary

Market Union Member Julia (547) had a merchant window but no store, so talking
to her opened an empty, non-working shop. In the original game she is a warp NPC
that moves players between Lorencia and the Loren Market, on both sides.

This wires her up to the warp window the game client already provides.

Changes

• Change Julia's NPC window to JuliaWarpMarketServer, so talking to her opens
  the client's Julia "Warp" window instead of an empty shop.
• Spawn a second instance of her in Lorencia (the entrance), at (139, 138).
• Add a handler for the EnterMarketPlaceRequest (sent by the window's "Warp"
  button) which warps the player to the other side: to the Loren Market when
  talking to her in Lorencia, and back to Lorencia when talking to her in the
  Loren Market.
• Add an optional configuration update (AddLorenMarketJuliaWarp) so existing
  servers get the same behaviour without re-initializing.

Notes

• The game client already implements the window, the button and the packet, so
  no client change is required.
• The warp targets each map's existing spawn gate; the di
  the map the player is currently on.
• The handler only acts while Julia's window is open, so the request can't be
  used as a free teleport.

Testing

• Fresh Season 6 initialization: Julia is spawned in both Lorencia and the Loren
  Market, with the correct NPC window.
• Applied the configuration update on an existing databas
• Verified in-game: talking to Julia warps the player both ways.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables the intended functionality for the NPC 'Market Union Member Julia', transforming her from a non-functional merchant into a functional warp point between Lorencia and the Loren Market. By leveraging existing client-side UI components and implementing a secure server-side handler, the changes provide a seamless travel experience while ensuring the warp mechanism cannot be exploited.

Highlights

• NPC Functionality Update: Updated Market Union Member Julia (547) to function as a warp NPC instead of an empty merchant, utilizing the existing client-side warp window.
• New Warp Handler: Implemented a new server-side packet handler to manage player movement between Lorencia and the Loren Market.
• World Spawn Adjustment: Added a new spawn instance of Julia in Lorencia to facilitate access to the Loren Market.
• Configuration Migration: Included an optional update plugin to apply these changes to existing server databases.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements a working warp NPC (Market Union Member Julia) to teleport players between Lorencia and the Loren Market. It introduces a new packet handler, EnterMarketPlaceHandlerPlugIn, and an update plugin to configure the NPC's window and spawn location. The feedback suggests an improvement in EnterMarketPlaceHandlerPlugIn to retrieve the target map and spawn gate more efficiently using existing context methods instead of querying the configuration directly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.