fix(cli): decode fixed32 OTLP span flags#234
Merged
Merged
Conversation
Makisuo
marked this pull request as ready for review
July 19, 2026 22:54
Contributor
|
Your Pullfrog Router balance is exhausted. You have a card on file but auto-reload is disabled, so runs paused once your balance went past the overdraft buffer. Top up balance → · Enable auto-reload →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Span.flagsandLink.flagsasfixed32Root cause
The local receiver declared the trace flags fields as
uint32, while the OTLP schema defines them asfixed32. Real SDKs therefore emitted a different wire type, and protobuf decoding could desynchronize or reject spans whose sampled flag was set.Impact
Local mode accepts sampled spans emitted by OpenTelemetry SDKs instead of returning HTTP 400, and preserves their flags value during decoding.
Validation
bun --filter @maple/cli test— 101 passedbun --filter @maple/cli typecheckbunx oxfmt --check apps/cli/src/server/otlp/proto.ts apps/cli/src/server/otlp/encode.test.tsbunx oxlint apps/cli/src/server/otlp/proto.ts apps/cli/src/server/otlp/encode.test.tsCloses #221
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.